-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensor_msgs/CompressedImage: updated description of format field #231
sensor_msgs/CompressedImage: updated description of format field #231
Conversation
Signed-off-by: ijnek <[email protected]>
79993d1
to
3c0c92d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@mjcarroll this one comes from ros/common_msgs#184, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In short, this looks good to me and does seem to correspond to what the code currently supports. I'm going to go ahead and run CI on it, thanks!
Thanks @fujitatomoya and @clalancette ! |
Is there any info on when this became outdated? Fwiw I'm pretty sure we support only the "simple" values and not the "verbose" ones in Foxglove, and I don't recall any complaints or feature requests about this, so I'm surprised to hear that the simple ones are unused.
If I'm reading this change correctly, the old "simple" format values of |
I don't have details on when simple jpeg, png, etc. were dropped (it may still work with compressed subscribers in image_transport_plugins, i'll have to give it a try), but comprssed publisher and compressed depth publisher from image_transport_plugins has been using the new format for at least 12 years (ros-perception/image_transport_plugins@e9c2768). As a side note, since compressed images and compressed depth images both use |
Signed-off-by: ijnek <[email protected]>
Port of ros/common_msgs#184 to ROS 2.
From original PR: